External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virsh: use faster bit search

Browse Source 
Now that gnulib gives us ffs, we might as well use it.

* tools/virsh.c (vshCmddefGetData): Use ffs rather than
count_one_bits.
This commit is contained in:
Eric Blake 2011-07-15 15:49:37 -06:00
parent 4b7a8e9c0d
commit 7e853d6c1a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh.c
View File

@ -32,6 +32,7 @@
#include <inttypes.h> #include <inttypes.h>
#include <signal.h> #include <signal.h>
#include <poll.h> #include <poll.h>
#include <strings.h>
#include <libxml/parser.h> #include <libxml/parser.h>
#include <libxml/tree.h> #include <libxml/tree.h>
@ -57,7 +58,6 @@
#include "configmake.h" #include "configmake.h"
#include "threads.h" #include "threads.h"
#include "command.h" #include "command.h"
#include "count-one-bits.h"
#include "virkeycode.h" #include "virkeycode.h"
static char *progname; static char *progname;
@ -12852,7 +12852,7 @@ vshCmddefGetData(const vshCmdDef *cmd, uint32_t *opts_need_arg,
return NULL; return NULL;
/* Grab least-significant set bit */ /* Grab least-significant set bit */
i = count_one_bits(*opts_need_arg ^ (*opts_need_arg - 1)) - 1; i = ffs(*opts_need_arg) - 1;
opt = &cmd->opts[i]; opt = &cmd->opts[i];
if (opt->type != VSH_OT_ARGV) if (opt->type != VSH_OT_ARGV)
*opts_need_arg &= ~(1 << i); *opts_need_arg &= ~(1 << i);