External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Resolve possible overrun

Browse Source 
Coverity noted that each of the fmemopen called used the strlen value
in order to allocate space, but that neglected space for terminating
null string. So just add 1 to the strlen.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
John Ferlan 2018-09-20 17:34:38 -04:00
parent f5c7d8890b
commit 7eb56dcd9e
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/vircgroupmock.c
View File

@ -466,12 +466,13 @@ FILE *fopen(const char *path, const char *mode)
if (STREQ(mode, "r")) {
if (allinone)
return fmemopen((void *)procmountsallinone,
strlen(procmountsallinone), mode);
strlen(procmountsallinone) + 1, mode);
else if (logind)
return fmemopen((void *)procmountslogind,
strlen(procmountslogind), mode);
strlen(procmountslogind) + 1, mode);
else
return fmemopen((void *)procmounts, strlen(procmounts), mode);
return fmemopen((void *)procmounts,
strlen(procmounts) + 1, mode);
} else {
errno = EACCES;
return NULL;
@ -481,12 +482,13 @@ FILE *fopen(const char *path, const char *mode)
if (STREQ(mode, "r")) {
if (allinone)
return fmemopen((void *)proccgroupsallinone,
strlen(proccgroupsallinone), mode);
strlen(proccgroupsallinone) + 1, mode);
else if (logind)
return fmemopen((void *)proccgroupslogind,
strlen(proccgroupslogind), mode);
strlen(proccgroupslogind) + 1, mode);
else
return fmemopen((void *)proccgroups, strlen(proccgroups), mode);
return fmemopen((void *)proccgroups,
strlen(proccgroups) + 1, mode);
} else {
errno = EACCES;
return NULL;
@ -496,12 +498,13 @@ FILE *fopen(const char *path, const char *mode)
if (STREQ(mode, "r")) {
if (allinone)
return fmemopen((void *)procselfcgroupsallinone,
strlen(procselfcgroupsallinone), mode);
strlen(procselfcgroupsallinone) + 1, mode);
else if (logind)
return fmemopen((void *)procselfcgroupslogind,
strlen(procselfcgroupslogind), mode);
strlen(procselfcgroupslogind) + 1, mode);
else
return fmemopen((void *)procselfcgroups, strlen(procselfcgroups), mode);
return fmemopen((void *)procselfcgroups,
strlen(procselfcgroups) + 1, mode);
} else {
errno = EACCES;
return NULL;