From 7f1ca3d6fec5eeb20b3612bca16a0b5d5c93c895 Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake@redhat.com>
Date: Wed, 16 Jul 2014 14:53:32 -0600
Subject: [PATCH] schema: put interleave at correct level

The previous commit 09d4d26 put the interleave at the wrong point;
it didn't allow interleaving with <memory>.

* docs/schema/domaincommon.rng (numatune): Fix interleave location.
* tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml: Adjust test.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 docs/schemas/domaincommon.rng                 | 68 +++++++++----------
 .../qemuxml2argv-numatune-memnode.xml         |  2 +-
 2 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index fb5bdb3a24..2caeef992c 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -759,38 +759,38 @@
   <!-- All the NUMA related tunables would go in the numatune -->
   <define name="numatune">
     <element name="numatune">
-      <optional>
-        <element name="memory">
-          <optional>
-            <attribute name="mode">
-              <choice>
-                <value>strict</value>
-                <value>preferred</value>
-                <value>interleave</value>
-              </choice>
-            </attribute>
-          </optional>
-          <choice>
-            <group>
-              <optional>
-                <attribute name='placement'>
-                  <value>static</value>
-                </attribute>
-              </optional>
-              <optional>
-                <attribute name='nodeset'>
-                  <ref name='cpuset'/>
-                </attribute>
-              </optional>
-            </group>
-            <attribute name='placement'>
-              <value>auto</value>
-            </attribute>
-              </choice>
-        </element>
-      </optional>
-      <zeroOrMore>
-        <interleave>
+      <interleave>
+        <optional>
+          <element name="memory">
+            <optional>
+              <attribute name="mode">
+                <choice>
+                  <value>strict</value>
+                  <value>preferred</value>
+                  <value>interleave</value>
+                </choice>
+              </attribute>
+            </optional>
+            <choice>
+              <group>
+                <optional>
+                  <attribute name='placement'>
+                    <value>static</value>
+                  </attribute>
+                </optional>
+                <optional>
+                  <attribute name='nodeset'>
+                    <ref name='cpuset'/>
+                  </attribute>
+                </optional>
+              </group>
+              <attribute name='placement'>
+                <value>auto</value>
+              </attribute>
+            </choice>
+          </element>
+        </optional>
+        <zeroOrMore>
           <element name="memnode">
             <attribute name="cellid">
               <ref name="unsignedInt"/>
@@ -806,8 +806,8 @@
               <ref name='cpuset'/>
             </attribute>
           </element>
-        </interleave>
-      </zeroOrMore>
+        </zeroOrMore>
+      </interleave>
     </element>
   </define>
 
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml
index 49b328cb18..440413bfc4 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml
@@ -5,8 +5,8 @@
   <currentMemory unit='KiB'>24682468</currentMemory>
   <vcpu placement='static'>32</vcpu>
   <numatune>
-    <memory mode='strict' nodeset='0-7'/>
     <memnode cellid='0' mode='preferred' nodeset='3'/>
+    <memory mode='strict' nodeset='0-7'/>
     <memnode cellid='2' mode='strict' nodeset='1-2,5-7,^6'/>
   </numatune>
   <os>