External/libvirt
1
0
Fork 0
Code

util: clang is failing to compile due to unused variables.

Browse Source 
After some recent patches, clang is throwing some errors related to
unused variables. This is not happening when we use GCC with -Werror
enabled. Only clang reports this warning.

make[3]: Entering directory '/home/julio/Desktop/virt/libvirt/src'
  CC       util/libvirt_util_la-virscsivhost.lo
  CC       util/libvirt_util_la-virusb.lo
  CC       util/libvirt_util_la-virmdev.lo
util/virmdev.c:373:36: error: unused variable 'ret' [-Werror,-Wunused-variable]
    VIR_AUTOPTR(virMediatedDevice) ret = virMediatedDeviceListSteal(list, dev);
                                   ^
1 error generated.
Makefile:11579: recipe for target 'util/libvirt_util_la-virmdev.lo' failed
make[3]: *** [util/libvirt_util_la-virmdev.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
util/virscsivhost.c:112:37: error: unused variable 'tmp' [-Werror,-Wunused-variable]
    VIR_AUTOPTR(virSCSIVHostDevice) tmp = virSCSIVHostDeviceListSteal(list, dev);
                                    ^
1 error generated.
Makefile:11411: recipe for target 'util/libvirt_util_la-virscsivhost.lo' failed
make[3]: *** [util/libvirt_util_la-virscsivhost.lo] Error 1
util/virusb.c:511:31: error: unused variable 'ret' [-Werror,-Wunused-variable]
    VIR_AUTOPTR(virUSBDevice) ret = virUSBDeviceListSteal(list, dev);

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Julio Faracco 2018-07-27 18:17:34 -03:00 committed by John Ferlan
parent 11a4d59345
commit 7f6d6b965a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/util/virmdev.c
View File

@ -370,7 +370,7 @@ void
virMediatedDeviceListDel(virMediatedDeviceListPtr list, virMediatedDeviceListDel(virMediatedDeviceListPtr list,
virMediatedDevicePtr dev) virMediatedDevicePtr dev)
{ {
VIR_AUTOPTR(virMediatedDevice) ret = virMediatedDeviceListSteal(list, dev); virMediatedDeviceFree(virMediatedDeviceListSteal(list, dev));
} }

2
src/util/virscsivhost.c
View File

@ -109,7 +109,7 @@ void
virSCSIVHostDeviceListDel(virSCSIVHostDeviceListPtr list, virSCSIVHostDeviceListDel(virSCSIVHostDeviceListPtr list,
virSCSIVHostDevicePtr dev) virSCSIVHostDevicePtr dev)
{ {
VIR_AUTOPTR(virSCSIVHostDevice) tmp = virSCSIVHostDeviceListSteal(list, dev); virSCSIVHostDeviceFree(virSCSIVHostDeviceListSteal(list, dev));
} }

2
src/util/virusb.c
View File

@ -508,7 +508,7 @@ void
virUSBDeviceListDel(virUSBDeviceListPtr list, virUSBDeviceListDel(virUSBDeviceListPtr list,
virUSBDevicePtr dev) virUSBDevicePtr dev)
{ {
VIR_AUTOPTR(virUSBDevice) ret = virUSBDeviceListSteal(list, dev); virUSBDeviceFree(virUSBDeviceListSteal(list, dev));
} }
virUSBDevicePtr virUSBDevicePtr