External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

macvtap: avoid invalid free

Browse Source 
Commit 0472f39 plugged a leak, but introduced another bug:

Actually looks like physfndev is conditionally allocated in getPhysfnDev
Its better to modify getPhysfnDev to allocate physfndev every time.
This commit is contained in:
Roopa Prabhu 2011-10-14 13:41:46 -07:00 committed by Eric Blake
parent 4040ff6638
commit 80b077ee5e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/macvtap.c
View File

@ -964,7 +964,11 @@ getPhysfnDev(const char *linkdev,
*/
*vf = PORT_SELF_VF;
*physfndev = (char *)linkdev;
*physfndev = strdup(linkdev);
if (!*physfndev) {
virReportOOMError();
rc = -1;
}
}
return rc;