External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-10 13:41:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: get rid of unnecessary umask() call

Browse Source 
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
(cherry picked from commit d00c6fd25854bfd4822f6ce3d769a8ca132ec31b)
This commit is contained in:
Martin Kletzander 2014-09-07 20:09:36 +02:00 committed by Eric Blake
parent a34ec87d2d
commit 818c5c6b83
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/virpidfile.c
View File

@ -545,17 +545,15 @@ virPidFileConstructPath(bool privileged,
if (virAsprintf(pidfile, "%s/run/%s.pid", statedir, progname) < 0) if (virAsprintf(pidfile, "%s/run/%s.pid", statedir, progname) < 0)
goto cleanup; goto cleanup;
} else { } else {
mode_t old_umask;
if (!(rundir = virGetUserRuntimeDirectory())) if (!(rundir = virGetUserRuntimeDirectory()))
goto cleanup; goto cleanup;
old_umask = umask(077); if (virFileMakePathWithMode(rundir, 0700) < 0) {
if (virFileMakePath(rundir) < 0) { virReportSystemError(errno,
umask(old_umask); _("Cannot create user runtime directory '%s'"),
rundir);
goto cleanup; goto cleanup;
} }
umask(old_umask);
if (virAsprintf(pidfile, "%s/%s.pid", rundir, progname) < 0) { if (virAsprintf(pidfile, "%s/%s.pid", rundir, progname) < 0) {
VIR_FREE(rundir); VIR_FREE(rundir);