External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

Fix virDiskNameToIndex to actually ignore partition numbers

Browse Source 
The docs for virDiskNameToIndex claim it ignores partition
numbers. In actual fact though, a code ordering bug means
that a partition number will cause the code to accidentally
multiply the result by 26.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2012-11-22 14:56:08 +00:00
parent a154f5f313
commit 81d6c4defe
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/util.c
View File

@ -2193,11 +2193,10 @@ int virDiskNameToIndex(const char *name) {
return -1; return -1;
for (i = 0; *ptr; i++) { for (i = 0; *ptr; i++) {
idx = (idx + (i < 1 ? 0 : 1)) * 26;
if (!c_islower(*ptr)) if (!c_islower(*ptr))
break; break;
idx = (idx + (i < 1 ? 0 : 1)) * 26;
idx += *ptr - 'a'; idx += *ptr - 'a';
ptr++; ptr++;
} }