External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: command: Check for empty network source when formatting drive cmd

Browse Source 
Use the virStorageSourceIsEmpty helper to determine whether the drive
source is empty rather than checking for src->path. This will fix start
of VM with empty network cdrom that would not report any error.
This commit is contained in:
Peter Krempa 2015-03-24 16:16:29 +01:00
parent df9361859d
commit 82f349a3a8
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/qemu/qemu_command.c
View File

@ -3290,6 +3290,10 @@ qemuGetDriveSourceString(virStorageSourcePtr src,
*source = NULL;
/* return 1 for empty sources */
if (virStorageSourceIsEmpty(src))
return 1;
if (conn) {
if (actualType == VIR_STORAGE_TYPE_NETWORK &&
src->auth &&
@ -3319,11 +3323,6 @@ qemuGetDriveSourceString(virStorageSourcePtr src,
case VIR_STORAGE_TYPE_BLOCK:
case VIR_STORAGE_TYPE_FILE:
case VIR_STORAGE_TYPE_DIR:
if (!src->path) {
ret = 1;
goto cleanup;
}
if (VIR_STRDUP(*source, src->path) < 0)
goto cleanup;