External/libvirt
1
0
Fork 0
Code

libxlDomainMigrationDstPrepareDef: remove use of temporary variable

Browse Source 
We can free 'def->name' directly.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com
This commit is contained in:
Peter Krempa 2020-06-11 10:16:34 +02:00
parent 63d08bec0b
commit 84a4208ed2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libxl/libxl_migration.c
View File

@ -449,7 +449,6 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivatePtr driver,
{ {
libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
virDomainDefPtr def; virDomainDefPtr def;
char *name = NULL;
if (!dom_xml) { if (!dom_xml) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@ -464,13 +463,12 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivatePtr driver,
goto cleanup; goto cleanup;
if (dname) { if (dname) {
name = def->name; VIR_FREE(def->name);
def->name = g_strdup(dname); def->name = g_strdup(dname);
} }
cleanup: cleanup:
virObjectUnref(cfg); virObjectUnref(cfg);
VIR_FREE(name);
return def; return def;
} }