External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 05:57:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable all warnings permanently & default to -Werror for GIT builds

Browse Source 
Given that we auto-detect whether each -Wxxxx flag is supported by
GCC, and we are warning-free and use automake silent rules, there
is no compelling reason to allow compile warnings to be disabled.

Replace the --enable-compile-warnings flag with a simpler
--enable-werror flag, which defaults to 'yes' if building
from GIT, or 'no' if building from tar.gz

This helps ensure that everyone writing patches for libvirt will
take care to fix their warning problems before submitting for
review

* autobuild.sh: Force -Werror
* configure.ac: Update for LIBVIRT_COMPILE_WARNINGS macro change
* m4/virt-compile-warnings.m4: Permanently enable all warnings,
  auto-enable Werror for GIT builds
This commit is contained in:
Daniel P. Berrange 2012-03-27 16:47:11 +01:00
parent 3a2fc2770b
commit 851117bd7a
3 changed files with 118 additions and 124 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
autobuild.sh
View File

@ -20,7 +20,7 @@ cd build
../autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \ ../autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
--enable-test-coverage \ --enable-test-coverage \
--disable-nls \ --disable-nls \
--enable-compile-warnings=error --enable-werror
# If the MAKEFLAGS envvar does not yet include a -j option, # If the MAKEFLAGS envvar does not yet include a -j option,
# add -jN where N depends on the number of processors. # add -jN where N depends on the number of processors.
@ -74,7 +74,7 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then
--build=$(uname -m)-pc-linux \ --build=$(uname -m)-pc-linux \
--host=i686-pc-mingw32 \ --host=i686-pc-mingw32 \
--prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \ --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \
--enable-compile-warnings=error \ --enable-werror \
--without-libvirtd \ --without-libvirtd \
--without-python --without-python

4
configure.ac
View File

@ -106,7 +106,7 @@ VERSION_SCRIPT_FLAGS=-Wl,--version-script=
VERSION_SCRIPT_FLAGS="-Wl,-M -Wl," VERSION_SCRIPT_FLAGS="-Wl,-M -Wl,"
AC_MSG_RESULT([$VERSION_SCRIPT_FLAGS]) AC_MSG_RESULT([$VERSION_SCRIPT_FLAGS])
LIBVIRT_COMPILE_WARNINGS([maximum]) LIBVIRT_COMPILE_WARNINGS
AC_MSG_CHECKING([for CPUID instruction]) AC_MSG_CHECKING([for CPUID instruction])
AC_COMPILE_IFELSE([AC_LANG_PROGRAM( AC_COMPILE_IFELSE([AC_LANG_PROGRAM(
@ -2820,7 +2820,7 @@ AC_MSG_NOTICE([])
AC_MSG_NOTICE([Miscellaneous]) AC_MSG_NOTICE([Miscellaneous])
AC_MSG_NOTICE([]) AC_MSG_NOTICE([])
AC_MSG_NOTICE([ Debug: $enable_debug]) AC_MSG_NOTICE([ Debug: $enable_debug])
AC_MSG_NOTICE([ Warnings: $enable_compile_warnings]) AC_MSG_NOTICE([ Use -Werror: $set_werror])
AC_MSG_NOTICE([Warning Flags: $WARN_CFLAGS]) AC_MSG_NOTICE([Warning Flags: $WARN_CFLAGS])
AC_MSG_NOTICE([ Readline: $lv_use_readline]) AC_MSG_NOTICE([ Readline: $lv_use_readline])
AC_MSG_NOTICE([ Python: $with_python]) AC_MSG_NOTICE([ Python: $with_python])

26
m4/virt-compile-warnings.m4
View File

@ -7,16 +7,15 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
dnl More compiler warnings dnl More compiler warnings
dnl ****************************** dnl ******************************
AC_ARG_ENABLE(compile-warnings, AC_ARG_ENABLE([werror],
[AC_HELP_STRING([--enable-compile-warnings=@<:@no/yes/error@:>@], AS_HELP_STRING([--enable-werror], [Use -Werror (if supported)]),
[Turn on compiler warnings])],, [set_werror="$enableval"],
[enable_compile_warnings="m4_default([$1],[yes])"]) [if test -d $srcdir/.git; then
is_git_version=true
case "$enable_compile_warnings" in set_werror=yes
no) else
try_compiler_flags="" set_werror=no
;; fi])
yes|minimum|maximum|error)
# List of warnings that are not relevant / wanted # List of warnings that are not relevant / wanted
@ -131,15 +130,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
gl_WARN_ADD([-Wno-suggest-attribute=pure]) gl_WARN_ADD([-Wno-suggest-attribute=pure])
gl_WARN_ADD([-Wno-suggest-attribute=const]) gl_WARN_ADD([-Wno-suggest-attribute=const])
if test "$enable_compile_warnings" = "error" if test "$set_werror" = "yes"
then then
gl_WARN_ADD([-Werror]) gl_WARN_ADD([-Werror])
fi fi
;;
*)
AC_MSG_ERROR(Unknown argument '$enable_compile_warnings' to --enable-compile-warnings)
;;
esac
WARN_LDFLAGS=$WARN_CFLAGS WARN_LDFLAGS=$WARN_CFLAGS
AC_SUBST([WARN_CFLAGS]) AC_SUBST([WARN_CFLAGS])