External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: testQemuCapsIterate: Don't ignore malformed file names

Browse Source 
If files whose name doesn't follow the expected format are added
to the repository, it's better to make the test suite fail than to
silently ignore them.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Andrea Bolognani 2019-10-22 18:31:09 +02:00
parent dea6c10946
commit 85394f676d
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/testutilsqemu.c
View File

@ -910,7 +910,7 @@ testQemuCapsIterate(const char *suffix,
goto cleanup;
while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH)) > 0) {
char *tmp = ent->d_name;
g_autofree char *tmp = g_strdup(ent->d_name);
char *base = NULL;
char *archName = NULL;
@ -918,9 +918,11 @@ testQemuCapsIterate(const char *suffix,
if (!virStringStripSuffix(tmp, suffix))
continue;
/* Find the last dot, moving on if none is present */
if (!(archName = strrchr(tmp, '.')))
continue;
/* Find the last dot */
if (!(archName = strrchr(tmp, '.'))) {
VIR_TEST_VERBOSE("malformed file name '%s'", ent->d_name);
goto cleanup;
}
/* The base name is everything before the last dot, and
* the architecture name everything after it */