External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: qemuxml2argv: fail also on unexpected pass

Browse Source 
If a test expects either a parse error or a failure but then there is
neither a parse error nor a failure, then properly mark the test as
failing, instead of failing later on (e.g. trying to open a
non-existing .args file).

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
This commit is contained in:
Pino Toscano 2017-09-07 14:19:37 +02:00 committed by Michal Privoznik
parent 4673999d0f
commit 85afb126ad
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/qemuxml2argvtest.c
View File

@ -463,6 +463,10 @@ testCompareXMLToArgv(const void *data)
goto ok;
goto cleanup;
}
if (flags & FLAG_EXPECT_PARSE_ERROR) {
VIR_TEST_DEBUG("passed instead of expected parse error");
goto cleanup;
}
priv = vm->privateData;
if (virBitmapParse("0-3", &priv->autoNodeset, 4) < 0)
@ -502,6 +506,10 @@ testCompareXMLToArgv(const void *data)
goto ok;
goto cleanup;
}
if (flags & FLAG_EXPECT_FAILURE) {
VIR_TEST_DEBUG("passed instead of expected failure");
goto cleanup;
}
if (!(actualargv = virCommandToString(cmd)))
goto cleanup;