External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: avoid deadlock in qemuDomainObjStopWorker

Browse Source 
We are dropping the only reference here so that the event loop thread
is going to be exited synchronously. In order to avoid deadlocks we
need to unlock the VM so that any handler being called can finish
execution and thus even loop thread be finished too.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Nikolay Shirokovskiy 2020-07-23 11:02:59 +03:00
parent f4fc3db920
commit 860a999802
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/qemu/qemu_domain.c
View File

@ -1722,11 +1722,21 @@ void
qemuDomainObjStopWorker(virDomainObjPtr dom)
{
qemuDomainObjPrivatePtr priv = dom->privateData;
virEventThread *eventThread;
if (priv->eventThread) {
g_object_unref(priv->eventThread);
priv->eventThread = NULL;
}
if (!priv->eventThread)
return;
/*
* We are dropping the only reference here so that the event loop thread
* is going to be exited synchronously. In order to avoid deadlocks we
* need to unlock the VM so that any handler being called can finish
* execution and thus even loop thread be finished too.
*/
eventThread = g_steal_pointer(&priv->eventThread);
virObjectUnlock(dom);
g_object_unref(eventThread);
virObjectLock(dom);
}