External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: Use consistent naming for blkdeviotune options

Browse Source 
All options started with underscores, but we switched them to dashes
later on, making the style consistent.  The latest addition, however,
did not respect that, so let's change that as well.  It is tempting to
just change the name instead of adding alias, especially since nobody
ever used it, which we know thanks to the fact that it didn't work.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2017-01-25 09:38:09 +01:00
parent a20e8bcad5
commit 862bea96d9
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/virsh-domain.c
View File

@ -1264,6 +1264,10 @@ static const vshCmdOptDef opts_blkdeviotune[] = {
.help = N_("I/O size in bytes")
},
{.name = "group_name",
.type = VSH_OT_ALIAS,
.help = "group-name"
},
{.name = "group-name",
.type = VSH_OT_STRING,
.help = N_("group name to share I/O quota between multiple drives")
},
@ -1398,8 +1402,8 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd)
VSH_ADD_IOTUNE(write-iops-sec-max-length, WRITE_IOPS_SEC_MAX_LENGTH);
#undef VSH_ADD_IOTUNE
if (vshCommandOptStringReq(ctl, cmd, "group_name", &group_name) < 0) {
vshError(ctl, "%s", _("Unable to parse group parameter"));
if (vshCommandOptStringReq(ctl, cmd, "group-name", &group_name) < 0) {
vshError(ctl, "%s", _("Unable to parse group-name parameter"));
goto cleanup;
}

4
tools/virsh.pod
View File

@ -1139,7 +1139,7 @@ command.
[I<read-bytes-sec-max-length>] [I<write-bytes-sec-max-length>]]
[[I<total-iops-sec-max-length>] |
[I<read-iops-sec-max-length>] [I<write-iops-sec-max-length>]]
[I<size-iops-sec>] [I<group_name>]
[I<size-iops-sec>] [I<group-name>]
Set or query the block disk io parameters for a block device of I<domain>.
I<device> specifies a unique target name (<target dev='name'/>) or source
@ -1179,7 +1179,7 @@ read I/O operations limit.
I<--write-iops-sec-max-length> specifies duration in seconds to allow maximum
write I/O operations limit.
I<--size-iops-sec> specifies size I/O operations limit per second.
I<--group_name> specifies group name to share I/O quota between multiple drives.
I<--group-name> specifies group name to share I/O quota between multiple drives.
For a qemu domain, if no name is provided, then the default is to have a single
group for each I<device>.