External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: virDomainGraphicsDefValidate: validate attribute 'network' for listen type 'network'

Browse Source 
Related: https://gitlab.com/libvirt/libvirt/-/issues/93
Signed-off-by: Amneesh Singh <natto@weirdnatto.in>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Amneesh Singh 2022-04-13 22:01:37 +05:30 committed by Martin Kletzander
parent d9f175379c
commit 871a071abb
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/conf/domain_validate.c
View File

@ -2381,10 +2381,35 @@ virDomainAudioDefValidate(const virDomainDef *def,
return 0; return 0;
} }
static int
virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def)
{
size_t i;
for (i = 0; i < def->nListens; i++) {
if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK &&
!def->listens[i].network) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("'network' attribute is required for "
"listen type 'network'"));
return -1;
}
}
return 0;
}
static int static int
virDomainGraphicsDefValidate(const virDomainDef *def, virDomainGraphicsDefValidate(const virDomainDef *def,
const virDomainGraphicsDef *graphics) const virDomainGraphicsDef *graphics)
{ {
if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC ||
graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE ||
graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_RDP) {
if (virDomainGraphicsDefListensValidate(graphics) < 0)
return -1;
}
if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC)
return virDomainEnsureAudioID(def, graphics->data.vnc.audioId); return virDomainEnsureAudioID(def, graphics->data.vnc.audioId);