External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

nodedev: Add testing for 'mdevctl stop'

Browse Source 
Test that we run 'mdevctl' with the proper arguments when we destroy
mediated devices with virNodeDeviceDestroy()

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Jonathon Jongsma 2020-06-18 16:06:03 -05:00 committed by Erik Skultety
parent 88043da227
commit 872c9b97c2
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/nodedevmdevctldata/mdevctl-stop.argv Normal file
View File

@ -0,0 +1 @@
$MDEVCTL_BINARY$ stop -u e2451f73-c95b-4124-b900-e008af37c576

41
tests/nodedevmdevctltest.c
View File

@ -110,6 +110,41 @@ testMdevctlStartHelper(const void *data)
jsonfile); jsonfile);
} }
static int
testMdevctlStop(const void *data)
{
const char *uuid = data;
virBuffer buf = VIR_BUFFER_INITIALIZER;
const char *actualCmdline = NULL;
int ret = -1;
g_autoptr(virCommand) cmd = NULL;
g_autofree char *cmdlinefile =
g_strdup_printf("%s/nodedevmdevctldata/mdevctl-stop.argv",
abs_srcdir);
cmd = nodeDeviceGetMdevctlStopCommand(uuid);
if (!cmd)
goto cleanup;
virCommandSetDryRun(&buf, NULL, NULL);
if (virCommandRun(cmd, NULL) < 0)
goto cleanup;
if (!(actualCmdline = virBufferCurrentContent(&buf)))
goto cleanup;
if (nodedevCompareToFile(actualCmdline, cmdlinefile) < 0)
goto cleanup;
ret = 0;
cleanup:
virBufferFreeAndReset(&buf);
virCommandSetDryRun(NULL, NULL, NULL);
return ret;
}
static void static void
nodedevTestDriverFree(virNodeDeviceDriverStatePtr drv) nodedevTestDriverFree(virNodeDeviceDriverStatePtr drv)
{ {
@ -248,11 +283,17 @@ mymain(void)
#define DO_TEST_START(filename) \ #define DO_TEST_START(filename) \
DO_TEST_START_FULL("QEMU", CREATE_DEVICE, filename) DO_TEST_START_FULL("QEMU", CREATE_DEVICE, filename)
#define DO_TEST_STOP(uuid) \
DO_TEST_FULL("mdevctl stop " uuid, testMdevctlStop, uuid)
/* Test mdevctl start commands */ /* Test mdevctl start commands */
DO_TEST_START("mdev_d069d019_36ea_4111_8f0a_8c9a70e21366"); DO_TEST_START("mdev_d069d019_36ea_4111_8f0a_8c9a70e21366");
DO_TEST_START("mdev_fedc4916_1ca8_49ac_b176_871d16c13076"); DO_TEST_START("mdev_fedc4916_1ca8_49ac_b176_871d16c13076");
DO_TEST_START("mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9"); DO_TEST_START("mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9");
/* Test mdevctl stop command, pass an arbitrary uuid */
DO_TEST_STOP("e2451f73-c95b-4124-b900-e008af37c576");
done: done:
nodedevTestDriverFree(driver); nodedevTestDriverFree(driver);