External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

Rewrite usage of StrToLong_ui in udevProcess{PCI,SCSI}

Browse Source 
Use virStrToLong_ui instead of udevStrToLong_ui, reformat the code
and report a more specific error message.
This commit is contained in:
Ján Tomko 2016-06-03 14:54:03 +02:00
parent 3775a2e174
commit 876a5da03e
1 changed files with 21 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
src/node_device/node_device_udev.c
View File

@ -429,33 +429,14 @@ static int udevProcessPCI(struct udev_device *device,
goto out; goto out;
} }
p = strrchr(syspath, '/'); if ((p = strrchr(syspath, '/')) == NULL ||
virStrToLong_ui(p + 1, &p, 16, &data->pci_dev.domain) < 0 || p == NULL ||
if ((p == NULL) || (udevStrToLong_ui(p+1, virStrToLong_ui(p + 1, &p, 16, &data->pci_dev.bus) < 0 || p == NULL ||
&p, virStrToLong_ui(p + 1, &p, 16, &data->pci_dev.slot) < 0 || p == NULL ||
16, virStrToLong_ui(p + 1, &p, 16, &data->pci_dev.function) < 0) {
&data->pci_dev.domain) == -1)) { virReportError(VIR_ERR_INTERNAL_ERROR,
goto out; _("failed to parse the PCI address from sysfs path: '%s'"),
} syspath);
if ((p == NULL) || (udevStrToLong_ui(p+1,
&p,
16,
&data->pci_dev.bus) == -1)) {
goto out;
}
if ((p == NULL) || (udevStrToLong_ui(p+1,
&p,
16,
&data->pci_dev.slot) == -1)) {
goto out;
}
if ((p == NULL) || (udevStrToLong_ui(p+1,
&p,
16,
&data->pci_dev.function) == -1)) {
goto out; goto out;
} }
@ -716,16 +697,11 @@ static int udevProcessSCSIHost(struct udev_device *device ATTRIBUTE_UNUSED,
filename = last_component(def->sysfs_path); filename = last_component(def->sysfs_path);
if (!(str = STRSKIP(filename, "host"))) { if (!(str = STRSKIP(filename, "host")) ||
VIR_ERROR(_("SCSI host found, but its udev name '%s' does " virStrToLong_ui(str, NULL, 0, &data->scsi_host.host) < 0) {
"not begin with 'host'"), filename); virReportError(VIR_ERR_INTERNAL_ERROR,
goto out; _("failed to parse SCSI host '%s'"),
} filename);
if (udevStrToLong_ui(str,
NULL,
0,
&data->scsi_host.host) == -1) {
goto out; goto out;
} }
@ -831,28 +807,14 @@ static int udevProcessSCSIDevice(struct udev_device *device ATTRIBUTE_UNUSED,
filename = last_component(def->sysfs_path); filename = last_component(def->sysfs_path);
if (udevStrToLong_ui(filename, &p, 10, &data->scsi.host) == -1) if (virStrToLong_ui(filename, &p, 10, &data->scsi.host) < 0 || p == NULL ||
goto out; virStrToLong_ui(p + 1, &p, 10, &data->scsi.bus) < 0 || p == NULL ||
virStrToLong_ui(p + 1, &p, 10, &data->scsi.target) < 0 || p == NULL ||
if ((p == NULL) || (udevStrToLong_ui(p+1, virStrToLong_ui(p + 1, &p, 10, &data->scsi.lun) < 0) {
&p, virReportError(VIR_ERR_INTERNAL_ERROR,
10, _("failed to parse the SCSI address from filename: '%s'"),
&data->scsi.bus) == -1)) { filename);
goto out; return -1;
}
if ((p == NULL) || (udevStrToLong_ui(p+1,
&p,
10,
&data->scsi.target) == -1)) {
goto out;
}
if ((p == NULL) || (udevStrToLong_ui(p+1,
&p,
10,
&data->scsi.lun) == -1)) {
goto out;
} }
switch (udevGetUintSysfsAttr(device, "type", &tmp, 0)) { switch (udevGetUintSysfsAttr(device, "type", &tmp, 0)) {