From 878cbd0f6a485c6256652e1a9f179b1f733d4902 Mon Sep 17 00:00:00 2001 From: Kristina Hanicova Date: Tue, 27 Jul 2021 14:36:00 +0200 Subject: [PATCH] qemu: save status xml after generating taint message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We didn't always save status xml after generating new taint message which resulted in it being deleted in case of a libvirtd restart. Some taint messages were preserved thanks to saving status xml separately at the end of the calling functions. With this, every taint message is saved, regardless of the calling functions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1965589 Signed-off-by: Kristina Hanicova Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index bc448e48a4..a05ebf871d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6463,7 +6463,10 @@ void qemuDomainObjTaint(virQEMUDriver *driver, virDomainTaintFlags taint, qemuDomainLogContext *logCtxt) { + g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); + qemuDomainObjTaintMsg(driver, obj, taint, logCtxt, NULL); + ignore_value(virDomainObjSave(obj, driver->xmlopt, cfg->stateDir)); } void qemuDomainObjTaintMsg(virQEMUDriver *driver,