External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

virDomainNetDefParseXML: Drop prehistoric error workaround

Browse Source 
Apart from it being a long time ago the 'openvz' driver is also rarely
used.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2022-09-16 18:25:19 +02:00
parent 3837f28515
commit 8802c38fd5
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/conf/domain_conf.c
View File

@ -8998,7 +8998,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
VIR_XPATH_NODE_AUTORESTORE(ctxt) VIR_XPATH_NODE_AUTORESTORE(ctxt)
int rv; int rv;
g_autofree char *macaddr = NULL; g_autofree char *macaddr = NULL;
g_autofree char *dev = NULL;
g_autofree char *model = NULL; g_autofree char *model = NULL;
g_autofree char *linkstate = NULL; g_autofree char *linkstate = NULL;
g_autofree char *tap = NULL; g_autofree char *tap = NULL;
@ -9120,25 +9119,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
break; break;
case VIR_DOMAIN_NET_TYPE_ETHERNET: case VIR_DOMAIN_NET_TYPE_ETHERNET:
/* This clause is only necessary because from 2010 to 2016 it was
* possible (but never documented) to configure the name of the
* guest-side interface of an openvz domain with <source dev='blah'/>.
* That was blatant misuse of <source>, so was likely (hopefully)
* never used, but just in case there was somebody using it, we
* need to generate an error. If the openvz driver is ever
* deprecated, this clause can be removed from here.
*/
if (source_node) {
if ((dev = virXMLPropString(source_node, "dev"))) {
virReportError(VIR_ERR_XML_ERROR,
_("Invalid attempt to set <interface type='ethernet'> "
"device name with <source dev='%s'/>. "
"Use <target dev='%s'/> (for host-side) "
"or <guest dev='%s'/> (for guest-side) instead."),
dev, dev, dev);
return NULL;
}
}
parse_filterref = true; parse_filterref = true;
break; break;