External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Add Taint for nbdkit restart failure

Browse Source 
Since the restart handler will trigger at an arbitrary time (when the
nbdkit process crashes, for instance), it's difficult to provide
feedback to the user if the restart is unsuccessful. Rather than just
relying on a warning in the log, taint the domain so that there will be
a slightly more user-visible notification.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Jonathon Jongsma 2023-08-21 16:04:35 -05:00
parent 0993f9f905
commit 8836f331d7
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conf/domain_conf.c
View File

@ -87,6 +87,7 @@ VIR_ENUM_IMPL(virDomainTaint,
"custom-hypervisor-feature", "custom-hypervisor-feature",
"deprecated-config", "deprecated-config",
"custom-device", "custom-device",
"nbdkit-restart",
); );
VIR_ENUM_IMPL(virDomainTaintMessage, VIR_ENUM_IMPL(virDomainTaintMessage,
@ -105,6 +106,7 @@ VIR_ENUM_IMPL(virDomainTaintMessage,
N_("hypervisor feature autodetection override"), N_("hypervisor feature autodetection override"),
N_("use of deprecated configuration settings"), N_("use of deprecated configuration settings"),
N_("custom device configuration"), N_("custom device configuration"),
N_("nbdkit restart failed"),
); );
VIR_ENUM_IMPL(virDomainVirt, VIR_ENUM_IMPL(virDomainVirt,

1
src/conf/domain_conf.h
View File

@ -3194,6 +3194,7 @@ typedef enum {
VIR_DOMAIN_TAINT_CUSTOM_HYPERVISOR_FEATURE, /* custom hypervisor feature control */ VIR_DOMAIN_TAINT_CUSTOM_HYPERVISOR_FEATURE, /* custom hypervisor feature control */
VIR_DOMAIN_TAINT_DEPRECATED_CONFIG, /* Configuration that is marked deprecated */ VIR_DOMAIN_TAINT_DEPRECATED_CONFIG, /* Configuration that is marked deprecated */
VIR_DOMAIN_TAINT_CUSTOM_DEVICE, /* hypervisor device config customized */ VIR_DOMAIN_TAINT_CUSTOM_DEVICE, /* hypervisor device config customized */
VIR_DOMAIN_TAINT_NBDKIT_RESTART, /* nbdkit could not be restarted */
VIR_DOMAIN_TAINT_LAST VIR_DOMAIN_TAINT_LAST
} virDomainTaintFlags; } virDomainTaintFlags;