External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 19:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: disk: Sanitize parsing of disk format

Browse Source
This commit is contained in:
Peter Krempa 2016-04-20 15:36:05 +02:00
parent f3f931b6c0
commit 8a3dea1f11
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/conf/domain_conf.c
View File

@ -6919,7 +6919,7 @@ static int
virDomainDiskDefDriverParseXML(virDomainDiskDefPtr def, virDomainDiskDefDriverParseXML(virDomainDiskDefPtr def,
xmlNodePtr cur) xmlNodePtr cur)
{ {
char *driverType = NULL; char *tmp = NULL;
char *cachetag = NULL; char *cachetag = NULL;
char *error_policy = NULL; char *error_policy = NULL;
char *rerror_policy = NULL; char *rerror_policy = NULL;
@ -6932,13 +6932,6 @@ virDomainDiskDefDriverParseXML(virDomainDiskDefPtr def,
int ret = -1; int ret = -1;
def->src->driverName = virXMLPropString(cur, "name"); def->src->driverName = virXMLPropString(cur, "name");
driverType = virXMLPropString(cur, "type");
if (STREQ_NULLABLE(driverType, "aio")) {
/* In-place conversion to "raw", for Xen back-compat */
driverType[0] = 'r';
driverType[1] = 'a';
driverType[2] = 'w';
}
cachetag = virXMLPropString(cur, "cache"); cachetag = virXMLPropString(cur, "cache");
error_policy = virXMLPropString(cur, "error_policy"); error_policy = virXMLPropString(cur, "error_policy");
rerror_policy = virXMLPropString(cur, "rerror_policy"); rerror_policy = virXMLPropString(cur, "rerror_policy");
@ -7033,20 +7026,25 @@ virDomainDiskDefDriverParseXML(virDomainDiskDefPtr def,
} }
} }
if (driverType) { if ((tmp = virXMLPropString(cur, "type"))) {
def->src->format = virStorageFileFormatTypeFromString(driverType); if (STREQ(tmp, "aio")) {
if (def->src->format <= 0) { /* Xen back-compat */
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, def->src->format = VIR_STORAGE_FILE_RAW;
_("unknown driver format value '%s'"), } else {
driverType); if ((def->src->format = virStorageFileFormatTypeFromString(tmp)) <= 0) {
goto cleanup; virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("unknown driver format value '%s'"), tmp);
goto cleanup;
}
} }
VIR_FREE(tmp);
} }
ret = 0; ret = 0;
cleanup: cleanup:
VIR_FREE(driverType); VIR_FREE(tmp);
VIR_FREE(cachetag); VIR_FREE(cachetag);
VIR_FREE(error_policy); VIR_FREE(error_policy);
VIR_FREE(rerror_policy); VIR_FREE(rerror_policy);