mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-31 14:07:16 +00:00
qemuDomainDeviceDefValidate: Validate watchdog
Currently we don't do it. Therefore we accept senseless combinations of models and buses they are attached to. Moreover, diag288 watchdog is exclusive to s390(x). Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
parent
5d7659027f
commit
8a54cc1d08
@ -3366,6 +3366,54 @@ qemuDomainRedirdevDefValidate(const virDomainRedirdevDef *def)
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
static int
|
||||||
|
qemuDomainWatchdogDefValidate(const virDomainWatchdogDef *dev,
|
||||||
|
const virDomainDef *def)
|
||||||
|
{
|
||||||
|
switch ((virDomainWatchdogModel) dev->model) {
|
||||||
|
case VIR_DOMAIN_WATCHDOG_MODEL_I6300ESB:
|
||||||
|
if (dev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
|
||||||
|
dev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
|
||||||
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||||
|
_("%s model of watchog can go only on PCI bus"),
|
||||||
|
virDomainWatchdogModelTypeToString(dev->model));
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
case VIR_DOMAIN_WATCHDOG_MODEL_IB700:
|
||||||
|
if (dev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
|
||||||
|
dev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA) {
|
||||||
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||||
|
_("%s model of watchog can go only on ISA bus"),
|
||||||
|
virDomainWatchdogModelTypeToString(dev->model));
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
case VIR_DOMAIN_WATCHDOG_MODEL_DIAG288:
|
||||||
|
if (dev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
|
||||||
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||||
|
_("%s model of watchog is virtual and cannot go on any bus."),
|
||||||
|
virDomainWatchdogModelTypeToString(dev->model));
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
if (!(ARCH_IS_S390(def->os.arch))) {
|
||||||
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||||
|
_("%s model of watchdog is allowed for s390 and s390x only"),
|
||||||
|
virDomainWatchdogModelTypeToString(dev->model));
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
case VIR_DOMAIN_WATCHDOG_MODEL_LAST:
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
static int
|
static int
|
||||||
qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
|
qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
|
||||||
const virDomainDef *def,
|
const virDomainDef *def,
|
||||||
@ -3474,6 +3522,9 @@ qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
|
|||||||
} else if (dev->type == VIR_DOMAIN_DEVICE_REDIRDEV) {
|
} else if (dev->type == VIR_DOMAIN_DEVICE_REDIRDEV) {
|
||||||
if (qemuDomainRedirdevDefValidate(dev->data.redirdev) < 0)
|
if (qemuDomainRedirdevDefValidate(dev->data.redirdev) < 0)
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
|
} else if (dev->type == VIR_DOMAIN_DEVICE_WATCHDOG) {
|
||||||
|
if (qemuDomainWatchdogDefValidate(dev->data.watchdog, def) < 0)
|
||||||
|
goto cleanup;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* forbid capabilities mode hostdev in this kind of hypervisor */
|
/* forbid capabilities mode hostdev in this kind of hypervisor */
|
||||||
|
Loading…
Reference in New Issue
Block a user