External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

lxc_fuse: Use automatic file closing

Browse Source 
There are two functions (lxcProcHostRead() and
lxcProcReadMeminfo()) that could benefit from automatic file
closing.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2022-02-28 15:21:31 +01:00
parent d68a8b2109
commit 8b36a2574f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lxc/lxc_fuse.c
View File

@ -126,7 +126,7 @@ lxcProcHostRead(char *path,
size_t size,
off_t offset)
{
int fd;
VIR_AUTOCLOSE fd = -1;
int res;
fd = open(path, O_RDONLY);
@ -136,7 +136,6 @@ lxcProcHostRead(char *path,
if ((res = pread(fd, buf, size, offset)) < 0)
res = -errno;
VIR_FORCE_CLOSE(fd);
return res;
}
@ -148,7 +147,7 @@ lxcProcReadMeminfo(char *hostpath,
off_t offset)
{
int res;
FILE *fp = NULL;
g_autoptr(FILE) fp = NULL;
g_autofree char *line = NULL;
size_t n;
struct virLXCMeminfo meminfo;
@ -251,7 +250,6 @@ lxcProcReadMeminfo(char *hostpath,
memcpy(buf, virBufferCurrentContent(new_meminfo), res);
cleanup:
VIR_FORCE_FCLOSE(fp);
return res;
}