External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 12:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

libxl: warn about ignored CPU mode=custom

Browse Source 
When support for mode=custom will be added in the future, semantics of
current config will change. Reduce the surprise by emitting a warning.

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Marek Marczykowski-Górecki 2018-04-12 03:03:21 +02:00 committed by Jim Fehlig
parent 446d091498
commit 8c49e04ecd
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libxl/libxl_conf.c
View File

@ -424,6 +424,12 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
libxl_defbool_set(&b_info->u.hvm.nested_hvm, hasHwVirt);
}
if (def->cpu && def->cpu->mode == VIR_CPU_MODE_CUSTOM) {
VIR_WARN("Ignoring CPU with mode=custom, update your config to "
"mode=host-passthrough to avoid risk of changed guest "
"semantics when mode=custom is supported in the future");
}
if (def->nsounds > 0) {
/*
* Use first sound device. man xl.cfg(5) describes soundhw as