From 8c618e17d16580342019b67ce51a9244b1f3444d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Fri, 25 Jan 2019 11:18:55 +0000 Subject: [PATCH] hyperv: use "is None" not "== None" for PEP-8 compliance MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PEP 8 says: "Comparisons to singletons like None should always be done with 'is' or 'is not', never the equality operators." There are potentially semantics differences, though in the case of this libvirt code its merely a style change: http://jaredgrubb.blogspot.com/2009/04/python-is-none-vs-none.html Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/hyperv/hyperv_wmi_generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py index fc1370955f..a9ece0ff00 100755 --- a/src/hyperv/hyperv_wmi_generator.py +++ b/src/hyperv/hyperv_wmi_generator.py @@ -65,7 +65,7 @@ class WmiClass: # because we'll generate "common" member and will be the "base" name if len(self.versions) > 1: first = self.versions[0] - if first.version == None: + if first.version is None: first.version = "v1" first.name = "%s_%s" % (first.name, first.version)