External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-30 09:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

virGetConnectGeneric: Only delegate existing identities

Browse Source 
Inside virt-qemu-run, just like in virsh for example, there is no
identity set in the current thread, so we should not try to set it,
otherwise things like connecting to other drivers might fail and on
top of that there is no error set so the user can't even see what's
wrong.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2000075

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Martin Kletzander 2022-11-11 14:19:50 +01:00
parent 15c11a7e54
commit 8e527dd653
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/driver.c
View File

@ -160,17 +160,15 @@ virGetConnectGeneric(virThreadLocal *threadPtr, const char *name)
if (conn->driver->connectSetIdentity != NULL) { if (conn->driver->connectSetIdentity != NULL) {
g_autoptr(virIdentity) ident = NULL; g_autoptr(virIdentity) ident = NULL;
g_autoptr(virTypedParamList) identparams = NULL;
VIR_DEBUG("Attempting to delegate current identity"); VIR_DEBUG("Attempting to delegate current identity");
if (!(ident = virIdentityGetCurrent())) ident = virIdentityGetCurrent();
goto error; if (ident) {
g_autoptr(virTypedParamList) tmp = virIdentityGetParameters(ident);
if (!(identparams = virIdentityGetParameters(ident))) if (virConnectSetIdentity(conn, tmp->par, tmp->npar, 0) < 0)
goto error; goto error;
}
if (virConnectSetIdentity(conn, identparams->par, identparams->npar, 0) < 0)
goto error;
} }
} }
return conn; return conn;