External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-24 21:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: migration: Disallow migration of read only disk

Browse Source 
Currently Libvirt allows attempts to migrate read only disks. Qemu
cannot handle this as read only disks cannot be written to on the
destination system. The end result is a cryptic error message and a
failed migration.

This patch causes migration to fail earlier and provides a meaningful
error message stating that migrating read only disks is not supported.

Signed-off-by: Corey S. McQuay <csmcquay@linux.vnet.ibm.com>
Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
This commit is contained in:
Corey S. McQuay 2016-09-26 13:16:00 -04:00 committed by Peter Krempa
parent 043ba4a40a
commit 8ee8f939fe
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_migration.c
View File

@ -1765,6 +1765,12 @@ qemuMigrationStartNBDServer(virQEMUDriverPtr driver,
if (!qemuMigrateDisk(disk, nmigrate_disks, migrate_disks))
continue;
if (disk->src->readonly) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
_("Cannot migrate read-only disk %s"), disk->dst);
goto cleanup;
}
VIR_FREE(diskAlias);
if (!(diskAlias = qemuAliasFromDisk(disk)))
goto cleanup;