From 9005a64b5cd2a064418572ec295532efb3df2798 Mon Sep 17 00:00:00 2001
From: Pavel Hrdina <phrdina@redhat.com>
Date: Sun, 9 Apr 2017 13:28:07 +0200
Subject: [PATCH] tests: fix some resource leaks

Found by running valgrind for these tests.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 tests/commandtest.c    | 3 +++
 tests/domaincapstest.c | 2 ++
 tests/fchosttest.c     | 2 ++
 tests/vircgroupmock.c  | 2 ++
 4 files changed, 9 insertions(+)

diff --git a/tests/commandtest.c b/tests/commandtest.c
index 80f10f88fc..1f6f16bcde 100644
--- a/tests/commandtest.c
+++ b/tests/commandtest.c
@@ -1093,6 +1093,9 @@ static int test25(const void *unused ATTRIBUTE_UNUSED)
         virCommandPtr cmd = virCommandNew("some/nonexistent/binary");
 
         rv = virCommandExec(cmd);
+
+        virCommandFree(cmd);
+
         if (safewrite(pipeFD[1], &rv, sizeof(rv)) < 0)
             fprintf(stderr, "Unable to write to pipe\n");
         _exit(EXIT_FAILURE);
diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c
index f871197c25..edf06c4e8e 100644
--- a/tests/domaincapstest.c
+++ b/tests/domaincapstest.c
@@ -534,6 +534,8 @@ mymain(void)
                  "/usr/bin/qemu-system-s390x", NULL,
                  "s390x", VIR_DOMAIN_VIRT_KVM);
 
+    virObjectUnref(cfg);
+
 #endif /* WITH_QEMU */
 
 #if WITH_LIBXL
diff --git a/tests/fchosttest.c b/tests/fchosttest.c
index ac4e92910d..3ee1912926 100644
--- a/tests/fchosttest.c
+++ b/tests/fchosttest.c
@@ -315,6 +315,7 @@ manageVHBAByStoragePool(const void *data)
         ignore_value(virStoragePoolDestroy(pool));
         goto cleanup;
     }
+    virNodeDeviceFree(dev);
 
     if (virStoragePoolDestroy(pool) < 0)
         goto cleanup;
@@ -322,6 +323,7 @@ manageVHBAByStoragePool(const void *data)
     if ((dev = virNodeDeviceLookupByName(conn, expect_hostname))) {
         VIR_DEBUG("Found expected_hostname '%s' after destroy",
                   expect_hostname);
+        virNodeDeviceFree(dev);
         goto cleanup;
     }
 
diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c
index ce6fd46266..9eb989ad7e 100644
--- a/tests/vircgroupmock.c
+++ b/tests/vircgroupmock.c
@@ -429,8 +429,10 @@ static void init_sysfs(void)
             abort();                                                   \
         if (make_controller(path, 0755) < 0) {                         \
             fprintf(stderr, "Cannot initialize %s\n", path);           \
+            free(path);                                                \
             abort();                                                   \
         }                                                              \
+        free(path);                                                    \
     } while (0)
 
     MAKE_CONTROLLER("cpu");