External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

storage_conf: Resolve Coverity RESOURCE_LEAK

Browse Source 
If there was a failure processing 'authdef' and the code went to cleanup
before the setting to source->auth, then it'd be leaked.
This commit is contained in:
John Ferlan 2014-08-27 15:40:57 -04:00
parent 69e433bc22
commit 91a60a560f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conf/storage_conf.c
View File

@ -661,6 +661,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt,
} }
source->auth = authdef; source->auth = authdef;
authdef = NULL;
} }
source->vendor = virXPathString("string(./vendor/@name)", ctxt); source->vendor = virXPathString("string(./vendor/@name)", ctxt);
@ -673,6 +674,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt,
VIR_FREE(port); VIR_FREE(port);
VIR_FREE(nodeset); VIR_FREE(nodeset);
VIR_FREE(adapter_type); VIR_FREE(adapter_type);
virStorageAuthDefFree(authdef);
return ret; return ret;
} }