External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

Fix leak of 'msg' object in client stream code

Browse Source 
In one exit path we forgot to free the virNetMessage object causing
a large memory leak for streams which send a lot of data. Some other
paths were calling VIR_FREE directly instead of virNetMessageFree
although this was (currently) harmless.

* src/rpc/virnetclientstream.c: Fix leak of msg object
* src/rpc/virnetclientprogram.c: Call virNetMessageFree instead
  of VIR_FREE
This commit is contained in:
Daniel P. Berrange 2011-07-08 12:35:36 +01:00
parent 3e5d48ef33
commit 927dfcf693
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/rpc/virnetclientprogram.c
View File

@ -329,11 +329,11 @@ int virNetClientProgramCall(virNetClientProgramPtr prog,
goto error; goto error;
} }
VIR_FREE(msg); virNetMessageFree(msg);
return 0; return 0;
error: error:
VIR_FREE(msg); virNetMessageFree(msg);
return -1; return -1;
} }

3
src/rpc/virnetclientstream.c
View File

@ -361,11 +361,12 @@ int virNetClientStreamSendPacket(virNetClientStreamPtr st,
if (virNetClientSend(client, msg, wantReply) < 0) if (virNetClientSend(client, msg, wantReply) < 0)
goto error; goto error;
virNetMessageFree(msg);
return nbytes; return nbytes;
error: error:
VIR_FREE(msg); virNetMessageFree(msg);
return -1; return -1;
} }