External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

network: restart dnsmasq after adding/removing txt and srv records

Browse Source 
Although dns host records are stored in a separate configuration file
that is reread by dnsmasq when it receives a SIGHUP, the txt and srv
records are directly in the dnsmasq .conf file which can't be reread
after initial dnsmasq startup. This means that if an srv or txt record
is modified in a network config, libvirt needs to restart the dnsmasq
process rather than just sending a SIGHUP.

This was pointed out in a question in
https://bugzilla.redhat.com/show_bug.cgi?id=988718 , but no separate
BZ was filed.
This commit is contained in:
Laine Stump 2016-05-31 11:51:29 -04:00
parent de0b091ae0
commit 93b59fcff6
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/network/bridge_driver.c
View File

@ -3404,9 +3404,14 @@ networkUpdate(virNetworkPtr net,
if (section == VIR_NETWORK_SECTION_BRIDGE || if (section == VIR_NETWORK_SECTION_BRIDGE ||
section == VIR_NETWORK_SECTION_DOMAIN || section == VIR_NETWORK_SECTION_DOMAIN ||
section == VIR_NETWORK_SECTION_IP || section == VIR_NETWORK_SECTION_IP ||
section == VIR_NETWORK_SECTION_IP_DHCP_RANGE) { section == VIR_NETWORK_SECTION_IP_DHCP_RANGE ||
/* these sections all change things on the dnsmasq commandline, section == VIR_NETWORK_SECTION_DNS_TXT ||
* so we need to kill and restart dnsmasq. section == VIR_NETWORK_SECTION_DNS_SRV) {
/* these sections all change things on the dnsmasq
* commandline (i.e. in the .conf file), so we need to
* kill and restart dnsmasq, because dnsmasq sets its uid
* to "nobody" after it starts, and is unable to re-read
* the conf file (owned by root, mode 600)
*/ */
if (networkRestartDhcpDaemon(driver, network) < 0) if (networkRestartDhcpDaemon(driver, network) < 0)
goto cleanup; goto cleanup;
@ -3434,12 +3439,10 @@ networkUpdate(virNetworkPtr net,
goto cleanup; goto cleanup;
} }
} else if (section == VIR_NETWORK_SECTION_DNS_HOST || } else if (section == VIR_NETWORK_SECTION_DNS_HOST) {
section == VIR_NETWORK_SECTION_DNS_TXT || /* this section only changes data in an external file
section == VIR_NETWORK_SECTION_DNS_SRV) { * (not the .conf file) so we can just update the config
/* these sections only change things in config files, so we * files and send SIGHUP to dnsmasq.
* can just update the config files and send SIGHUP to
* dnsmasq.
*/ */
if (networkRefreshDhcpDaemon(driver, network) < 0) if (networkRefreshDhcpDaemon(driver, network) < 0)
goto cleanup; goto cleanup;