External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-30 18:03:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

vbox: Reset @ret after xmlFreeNode

Browse Source 
In the error path, if we xmlFreeNode @ret, then the return ret;
a few lines later returns something that's already been free'd
and could be reused, so let's reinit it.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
John Ferlan 2019-12-16 07:36:32 -05:00
parent 010571240d
commit 93b8c6b119
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/vbox/vbox_snapshot_conf.c
View File

@ -352,6 +352,7 @@ virVBoxSnapshotConfCreateHardDiskNode(virVBoxSnapshotConfHardDiskPtr hardDisk)
if (result < 0) { if (result < 0) {
xmlUnlinkNode(ret); xmlUnlinkNode(ret);
xmlFreeNode(ret); xmlFreeNode(ret);
ret = NULL;
} }
VIR_FREE(uuid); VIR_FREE(uuid);
return ret; return ret;