External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-01 17:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: driver: Don't copy disk alias in qemuDomainBlocksStatsGather

Browse Source 
The string is not modified so it does not make sense to have a copy.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2018-08-03 14:50:06 +02:00
parent da7123a686
commit 93fad53d3e
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/qemu/qemu_driver.c
View File

@ -11069,7 +11069,7 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
virHashTablePtr blockstats = NULL;
qemuBlockStatsPtr stats;
int nstats;
char *diskAlias = NULL;
const char *entryname = NULL;
int ret = -1;
if (*path) {
@ -11084,8 +11084,7 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
goto cleanup;
}
if (VIR_STRDUP(diskAlias, disk->info.alias) < 0)
goto cleanup;
entryname = disk->info.alias;
}
qemuDomainObjEnterMonitor(driver, vm);
@ -11101,10 +11100,10 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
if (VIR_ALLOC(*retstats) < 0)
goto cleanup;
if (diskAlias) {
if (!(stats = virHashLookup(blockstats, diskAlias))) {
if (entryname) {
if (!(stats = virHashLookup(blockstats, entryname))) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("cannot find statistics for device '%s'"), diskAlias);
_("cannot find statistics for device '%s'"), entryname);
goto cleanup;
}
@ -11116,7 +11115,6 @@ qemuDomainBlocksStatsGather(virQEMUDriverPtr driver,
ret = nstats;
cleanup:
VIR_FREE(diskAlias);
virHashFree(blockstats);
return ret;
}