External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu_validate: Check if QEMU's capable of setting <defaultiothread/> pool size

Browse Source 
Since the main-loop and iothread classes are derived from the
same class (EventLoopBaseClass) we don't need new capability and
can use QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX directly to check
whether QEMU's capable of setting defaultiothread pool size.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik 2022-05-16 13:57:18 +02:00
parent 3e4bebb9d1
commit 94b71589f1
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/qemu/qemu_validate.c
View File

@ -389,18 +389,30 @@ qemuValidateDomainDefIOThreads(const virDomainDef *def,
virQEMUCaps *qemuCaps)
{
size_t i;
bool needsThreadPoolCap = false;
for (i = 0; i < def->niothreadids; i++) {
virDomainIOThreadIDDef *iothread = def->iothreadids[i];
if ((iothread->thread_pool_min != -1 || iothread->thread_pool_max != -1) &&
!virQEMUCapsGet(qemuCaps, QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX)) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("thread_pool_min and thread_pool_max is not supported by this QEMU binary"));
return -1;
if (iothread->thread_pool_min != -1 || iothread->thread_pool_max != -1) {
needsThreadPoolCap = true;
break;
}
}
if (def->defaultIOThread &&
(def->defaultIOThread->thread_pool_min >= 0 ||
def->defaultIOThread->thread_pool_max >= 0)) {
needsThreadPoolCap = true;
}
if (needsThreadPoolCap &&
!virQEMUCapsGet(qemuCaps, QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX)) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("thread_pool_min and thread_pool_max is not supported by this QEMU binary"));
return -1;
}
return 0;
}