External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

remoteDispatchDomainMigratePrepare*: Don't pass uninitialized variable to VIR_FREE

Browse Source 
'uri_out' may be passed to VIR_FREE uninitialized if 'conn' is NULL.
Unfortunately the compiler isn't able to detect this problem when
VIR_FREE is implemented using g_clear_pointer. Initialize the variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com
This commit is contained in:
Peter Krempa 2020-06-11 10:34:21 +02:00
parent c5c0dc3c81
commit 94f26f01bd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/remote/remote_daemon_dispatch.c
View File

@ -3030,7 +3030,7 @@ remoteDispatchDomainMigratePrepare(virNetServerPtr server G_GNUC_UNUSED,
char *cookie = NULL;
int cookielen = 0;
char *uri_in;
char **uri_out;
char **uri_out = NULL;
char *dname;
int rv = -1;
virConnectPtr conn = remoteGetHypervisorConn(client);
@ -3082,7 +3082,7 @@ remoteDispatchDomainMigratePrepare2(virNetServerPtr server G_GNUC_UNUSED,
char *cookie = NULL;
int cookielen = 0;
char *uri_in;
char **uri_out;
char **uri_out = NULL;
char *dname;
int rv = -1;
virConnectPtr conn = remoteGetHypervisorConn(client);
@ -4789,7 +4789,7 @@ remoteDispatchDomainMigratePrepare3(virNetServerPtr server G_GNUC_UNUSED,
char *cookieout = NULL;
int cookieoutlen = 0;
char *uri_in;
char **uri_out;
char **uri_out = NULL;
char *dname;
int rv = -1;
virConnectPtr conn = remoteGetHypervisorConn(client);
@ -5584,7 +5584,7 @@ remoteDispatchDomainMigratePrepare3Params(virNetServerPtr server G_GNUC_UNUSED,
int nparams = 0;
char *cookieout = NULL;
int cookieoutlen = 0;
char **uri_out;
char **uri_out = NULL;
int rv = -1;
virConnectPtr conn = remoteGetHypervisorConn(client);