From 950ca9e736ac4a075c024f7815eff75126814dd9 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 9 Mar 2018 09:48:07 -0500 Subject: [PATCH] vmware: Properly clean up in vmwareDomainLookupByName The virDomainObjListFindByName returns a locked and reffed domain object, all we did was unlock it, leaving an extra ref. Use the virDomainObjEndAPI to cleanup instead. Signed-off-by: John Ferlan Reviewed-by: Pavel Hrdina --- src/vmware/vmware_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index b4b809f1a8..783496f4de 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -922,8 +922,7 @@ vmwareDomainLookupByName(virConnectPtr conn, const char *name) dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); cleanup: - if (vm) - virObjectUnlock(vm); + virDomainObjEndAPI(&vm); return dom; }