From 95c8ddd2eca90e3024a6f74af84517c1e0115a60 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 24 Mar 2010 09:32:43 +0100
Subject: [PATCH] maint: add syntax-check rule to prohibit use of test's -a
 operator

* cfg.mk (sc_prohibit_test_minus_a): New rule.
---
 cfg.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index 2d0d278e14..4302338cc8 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -269,6 +269,12 @@ sc_preprocessor_indentation:
 	  echo '$(ME): skipping test $@: cppi not installed' 1>&2;	\
 	fi
 
+# Using test's -a operator is not portable.
+sc_prohibit_test_minus_a:
+	@re='\<test .+ -[a] '						\
+	msg='use "test C1 && test C2, not "test C1 -''a C2"'		\
+	  $(_prohibit_regexp)
+
 sc_copyright_format:
 	@$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright .*Red 'Hat	\
 	  | grep -v Inc							\