From 963ac787c4f7aa703d8082f2fc737f64e72f4b56 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 16 Feb 2022 16:20:23 +0100 Subject: [PATCH] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_TYPED_PARAM_STRING MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was a lockout to make strings in typed parameters compatible with versions which didn't have them. Now all drivers need to expose this capability. This namely enables it for 'esx' and 'vz' drivers, while they don't seem to be implementing any parameters for now, they might later. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/driver.c b/src/driver.c index 9852a1cb17..d070861cfd 100644 --- a/src/driver.c +++ b/src/driver.c @@ -353,7 +353,13 @@ virDriverFeatureIsGlobal(virDrvFeature feat, *supported = 0; return true; + /* Limitation of string support in typed parameters was an RPC limitation. + * At this point everything supports them and thus also drivers need to + * always advertise this feature */ case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + *supported = 1; + return true; + case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: case VIR_DRV_FEATURE_MIGRATION_V2: