External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemuDomainUSBAddressAddHubs: Refactor cleanup

Browse Source 
'hub' doesn't need to be freed any more because it's always consumed and
NULLed-out by VIR_APPEND element. This also makes the 'ret' variable
obsolete.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-08-04 11:08:49 +02:00
parent 18e65eef04
commit 966ba852b7
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_domain_address.c
View File

@ -2942,7 +2942,6 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
virDomainHubDef *hub = NULL; virDomainHubDef *hub = NULL;
size_t available_ports; size_t available_ports;
size_t hubs_needed = 0; size_t hubs_needed = 0;
int ret = -1;
size_t i; size_t i;
available_ports = virDomainUSBAddressCountAllPorts(def); available_ports = virDomainUSBAddressCountAllPorts(def);
@ -2972,9 +2971,7 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
VIR_APPEND_ELEMENT(def->hubs, def->nhubs, hub); VIR_APPEND_ELEMENT(def->hubs, def->nhubs, hub);
} }
ret = 0; return 0;
VIR_FREE(hub);
return ret;
} }