External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-23 20:02:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null

Browse Source 
The function sanlock_inquire can return NULL in the state string if the
message consists only of a header. The return value is arbitrary and
sent by the server. We should proceed carefully while touching such
pointers.
This commit is contained in:
Peter Krempa 2012-03-07 15:04:33 +01:00
parent 3bf5f0427a
commit 96b41f639d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/locking/lock_driver_sanlock.c
View File

@ -828,7 +828,7 @@ static int virLockManagerSanlockRelease(virLockManagerPtr lock,
return -1; return -1;
} }
if (STREQ(*state, "")) if (STREQ_NULLABLE(*state, ""))
VIR_FREE(*state); VIR_FREE(*state);
} }
@ -871,7 +871,7 @@ static int virLockManagerSanlockInquire(virLockManagerPtr lock,
return -1; return -1;
} }
if (STREQ(*state, "")) if (STREQ_NULLABLE(*state, ""))
VIR_FREE(*state); VIR_FREE(*state);
return 0; return 0;