External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-23 20:02:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmware: Fix some initialization problems

Browse Source 
Don't leak guest if adding it to virCapabilities fails.  Also return
NULL and not pointer to free'd object with zero references in such
case.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2017-03-15 09:10:12 +01:00
parent e8e9a7e9f7
commit 97a84a9344
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/vmware/vmware_conf.c
View File

@ -105,14 +105,15 @@ vmwareCapsInit(void)
VIR_DOMAIN_VIRT_VMWARE, VIR_DOMAIN_VIRT_VMWARE,
NULL, NULL, 0, NULL) == NULL) NULL, NULL, 0, NULL) == NULL)
goto error; goto error;
guest = NULL;
} }
cleanup:
return caps; return caps;
error: error:
virCapabilitiesFreeGuest(guest);
virObjectUnref(caps); virObjectUnref(caps);
goto cleanup; return NULL;
} }
int int