External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 22:17:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc'

Browse Source 
The function 'xmlSaveFormatFileEnc' has a last option to set
if you want to format dumped xml with whitespaces or not.

Older libxml2, the one used in RHEL6, take this option as it is
but newer libxml2 check this option if it's true or not. This
small difference somehow makes things messy on RHEL6 and generated
xml had extra new line and extra whitespaces.

We should pass 1 instead if -1 because the -1 confuses the libxml2.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2014-06-18 14:13:26 +02:00
parent 37c3585b7b
commit 97af511b1a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vbox/vbox_snapshot_conf.c
View File

@ -1211,7 +1211,7 @@ virVBoxSnapshotConfSaveVboxFile(virVBoxSnapshotConfMachinePtr machine,
}
}
if (xmlSaveFormatFileEnc(filePath, xml, "ISO-8859-1", -1) < 0) {
if (xmlSaveFormatFileEnc(filePath, xml, "ISO-8859-1", 1) < 0) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("Unable to save the xml"));
goto cleanup;