External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

conf: Don't leak 'primary' video property on error

Browse Source 
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
This commit is contained in:
Christophe Fergeau 2013-02-21 16:21:31 +01:00
parent 058273d096
commit 9879fce9f6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/domain_conf.c
View File

@ -7662,9 +7662,11 @@ virDomainVideoDefParseXML(const xmlNodePtr node,
vram = virXMLPropString(cur, "vram"); vram = virXMLPropString(cur, "vram");
heads = virXMLPropString(cur, "heads"); heads = virXMLPropString(cur, "heads");
if ((primary = virXMLPropString(cur, "primary")) != NULL) if ((primary = virXMLPropString(cur, "primary")) != NULL) {
if (STREQ(primary, "yes")) if (STREQ(primary, "yes"))
def->primary = 1; def->primary = 1;
VIR_FREE(primary);
}
def->accel = virDomainVideoAccelDefParseXML(cur); def->accel = virDomainVideoAccelDefParseXML(cur);
} }
@ -7728,7 +7730,6 @@ virDomainVideoDefParseXML(const xmlNodePtr node,
VIR_FREE(ram); VIR_FREE(ram);
VIR_FREE(vram); VIR_FREE(vram);
VIR_FREE(heads); VIR_FREE(heads);
VIR_FREE(primary);
return def; return def;