External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 04:15:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

scripts: check-aclrules: use in instead of find

Browse Source 
For checking whether a substring is present in a string,
using the pattern:
    "str" in string
is slightly faster than:
    string.find("str") != -1

Use it to shave off 4 % of the runtime of this script that
processes quite a few long source files.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Ján Tomko 2019-11-20 19:05:13 +01:00
parent 424a385c3a
commit 988f02a99c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/check-aclrules.py
View File

@ -97,7 +97,7 @@ def fixup_name(name):
def name_to_ProcName(name):
elems = []
if name.find("_") != -1 or name.lower() in ["open", "close"]:
if "_" in name or name.lower() in ["open", "close"]:
elems = [n.lower().capitalize() for n in name.split("_")]
else:
elems = [name]
@ -116,11 +116,11 @@ with open(proto, "r") as fh:
filtered = False
for line in fh:
if line.find("/**") != -1:
if "/**" in line:
incomment = True
filtered = False
elif incomment:
if line.find("* @aclfilter") != -1:
if "* @aclfilter" in line:
filtered = True
elif filtered:
m = re.search(r'''REMOTE_PROC_(.*)\s+=\s*\d+''', line)
@ -211,7 +211,7 @@ def process_file(filename):
# an ACL function
if intable:
assign = re.search(r'''\.(\w+)\s*=\s*(\w+),?''', line)
if line.find("}") != -1:
if "}" in line:
intable = False
table = None
elif assign is not None:
@ -247,9 +247,9 @@ def process_file(filename):
intable = True
table = name
if line.find("{") != -1:
if "{" in line:
brace = brace + 1
if line.find("}") != -1:
if "}" in line:
brace = brace - 1
return errs