External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 15:45:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash in nwfilter driver check

Browse Source 
The nwfilterDriverActive() could de-reference a NULL pointer
if it hadn't be started at the point it was called. It was
also not thread safe, since it lacked locking around data
accesses.

* src/nwfilter/nwfilter_driver.c: Fix locking & NULL checks
  in nwfilterDriverActive()
This commit is contained in:
Daniel P. Berrange 2010-04-19 14:16:46 +01:00
parent 3022375da3
commit 98bd5e6c5a
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/nwfilter/nwfilter_driver.c
View File

@ -164,9 +164,16 @@ nwfilterDriverReload(void) {
*/ */
static int static int
nwfilterDriverActive(void) { nwfilterDriverActive(void) {
if (!driverState->pools.count) int ret;
if (!driverState)
return 0; return 0;
return 1;
nwfilterDriverLock(driverState);
ret = driverState->pools.count ? 1 : 0;
nwfilterDriverUnlock(driverState);
return ret;
} }
/** /**