From 993351ff62f5b9c7c35c00ab83a814158bd64044 Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Tue, 2 Feb 2021 12:51:48 -0500 Subject: [PATCH] build: fix specfile logic for disabling netcf MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I *thought* I had tested all the combinations of manually setting --without netcf, different versions of Fedora, etc, but apparently not. The check in libvirt.spec.in to see if the target was an older Fedora or older RHEL would alway resolve to true, because, e.g., if {?fedora} is undefined, then "0%{?fedora} < 34" is "0 < 34", which is always true. Since both {?fedora} and {?rhel} are never defined at the same time, the result of the entire expression is always true. Fix this by qualifying each subexpression. Fixes: 35d5b26aa433bd33f4b33be3dbb67313357f97f9 Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrangé --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 34b481c69e..29b476184d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -146,7 +146,7 @@ %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif -%if 0%{?fedora} < 34 || 0%{?rhel} < 9 +%if (0%{?fedora} && 0%{?fedora} < 34) || (0%{?rhel} && 0%{?rhel} < 9) %define with_netcf 0%{!?_without_netcf:1} %endif