From 9961e7799a6943655e5a976e62e789deded576ef Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 11 Jun 2019 15:16:09 +0200 Subject: [PATCH] qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit 76b9aba2ba6 I tried to refactor qemuDomainStorageSourceAccessAllow but used wrong operators for adding bitwise flags. This way the flags would result in 0 if any of them would be applied. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 4d3a8868b2..e521bd3982 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9491,10 +9491,10 @@ qemuDomainStorageSourceAccessAllow(virQEMUDriverPtr driver, qemuDomainStorageSourceAccessFlags flags = QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_SKIP_REVOKE; if (readonly) - flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY; + flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY; if (!newSource) - flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS; + flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS; return qemuDomainStorageSourceAccessModify(driver, vm, elem, flags); }