External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-01 17:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

vircgroup: drop @create from virCgroupNewDomainPartition

Browse Source 
All callers pass true.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Pavel Hrdina 2020-10-22 01:43:57 +02:00
parent 085590fee4
commit 99d2c6519a
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/vircgroup.c
View File

@ -969,7 +969,6 @@ int
virCgroupNewDomainPartition(virCgroupPtr partition, virCgroupNewDomainPartition(virCgroupPtr partition,
const char *driver, const char *driver,
const char *name, const char *name,
bool create,
virCgroupPtr *group) virCgroupPtr *group)
{ {
g_autofree char *grpname = NULL; g_autofree char *grpname = NULL;
@ -993,7 +992,7 @@ virCgroupNewDomainPartition(virCgroupPtr partition,
* a group for driver, is to avoid overhead to track * a group for driver, is to avoid overhead to track
* cumulative usage that we don't need. * cumulative usage that we don't need.
*/ */
if (virCgroupMakeGroup(partition, newGroup, create, if (virCgroupMakeGroup(partition, newGroup, true,
VIR_CGROUP_MEM_HIERACHY) < 0) { VIR_CGROUP_MEM_HIERACHY) < 0) {
return -1; return -1;
} }
@ -1278,7 +1277,6 @@ virCgroupNewMachineManual(const char *name,
if (virCgroupNewDomainPartition(parent, if (virCgroupNewDomainPartition(parent,
drivername, drivername,
name, name,
true,
&newGroup) < 0) &newGroup) < 0)
return -1; return -1;
@ -2836,7 +2834,6 @@ int
virCgroupNewDomainPartition(virCgroupPtr partition G_GNUC_UNUSED, virCgroupNewDomainPartition(virCgroupPtr partition G_GNUC_UNUSED,
const char *driver G_GNUC_UNUSED, const char *driver G_GNUC_UNUSED,
const char *name G_GNUC_UNUSED, const char *name G_GNUC_UNUSED,
bool create G_GNUC_UNUSED,
virCgroupPtr *group G_GNUC_UNUSED) virCgroupPtr *group G_GNUC_UNUSED)
{ {
virReportSystemError(ENXIO, "%s", virReportSystemError(ENXIO, "%s",

1
src/util/vircgrouppriv.h
View File

@ -123,7 +123,6 @@ int virCgroupNewPartition(const char *path,
int virCgroupNewDomainPartition(virCgroupPtr partition, int virCgroupNewDomainPartition(virCgroupPtr partition,
const char *driver, const char *driver,
const char *name, const char *name,
bool create,
virCgroupPtr *group) virCgroupPtr *group)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5); ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5);

4
tests/vircgrouptest.c
View File

@ -434,7 +434,7 @@ static int testCgroupNewForPartitionDomain(const void *args G_GNUC_UNUSED)
return -1; return -1;
} }
if ((rv = virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo", true, &domaincgroup)) != 0) { if ((rv = virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo", &domaincgroup)) != 0) {
fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv); fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv);
return -1; return -1;
} }
@ -475,7 +475,7 @@ static int testCgroupNewForPartitionDomainEscaped(const void *args G_GNUC_UNUSED
return -1; return -1;
} }
if ((rv = virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.foo", true, &domaincgroup)) != 0) { if ((rv = virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.foo", &domaincgroup)) != 0) {
fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv); fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv);
return -1; return -1;
} }