External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 07:17:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Move comments to virQEMUCapsGuestIsNative()

Browse Source 
The function performing the checks, rather than its callers,
should contain comments explaining the rationale behind said
checks.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Andrea Bolognani 2018-09-18 13:32:29 +02:00
parent c846767bfa
commit 99d5a516d0
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/qemu/qemu_capabilities.c
View File

@ -631,15 +631,19 @@ bool
virQEMUCapsGuestIsNative(virArch host, virQEMUCapsGuestIsNative(virArch host,
virArch guest) virArch guest)
{ {
/* host & guest arches match */
if (host == guest) if (host == guest)
return true; return true;
/* hostarch is x86_64 and guest arch is i686 (needs -cpu qemu32) */
if (host == VIR_ARCH_X86_64 && guest == VIR_ARCH_I686) if (host == VIR_ARCH_X86_64 && guest == VIR_ARCH_I686)
return true; return true;
/* hostarch is aarch64 and guest arch is armv7l (needs -cpu aarch64=off) */
if (host == VIR_ARCH_AARCH64 && guest == VIR_ARCH_ARMV7L) if (host == VIR_ARCH_AARCH64 && guest == VIR_ARCH_ARMV7L)
return true; return true;
/* hostarch and guestarch are both ppc64 */
if (ARCH_IS_PPC64(host) && ARCH_IS_PPC64(guest)) if (ARCH_IS_PPC64(host) && ARCH_IS_PPC64(guest))
return true; return true;
@ -753,12 +757,6 @@ virQEMUCapsInitGuest(virCapsPtr caps,
} }
} }
/* qemu-kvm/kvm binaries can only be used if
* - host & guest arches match
* - hostarch is x86_64 and guest arch is i686 (needs -cpu qemu32)
* - hostarch is aarch64 and guest arch is armv7l (needs -cpu aarch64=off)
* - hostarch and guestarch are both ppc64*
*/
if (virQEMUCapsGuestIsNative(hostarch, guestarch)) { if (virQEMUCapsGuestIsNative(hostarch, guestarch)) {
const char *kvmbins[] = { const char *kvmbins[] = {
"/usr/libexec/qemu-kvm", /* RHEL */ "/usr/libexec/qemu-kvm", /* RHEL */