External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 19:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

remote: slightly improve debugging of socket selection

Browse Source 
The current debug message reports the "mode" after selection has
completed, however, the "mode" value can be changed by the selection
logic. It is thus beneficial to report most values upfront, and only
report newly changed values at the end.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2020-09-16 14:51:47 +01:00
parent ecfc4094d8
commit 9a71e969b5
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/remote/remote_sockets.c
View File

@ -145,6 +145,11 @@ remoteGetUNIXSocket(remoteDriverTransport transport,
g_autofree char *direct_sock_name = NULL;
g_autofree char *legacy_sock_name = NULL;
VIR_DEBUG("Choosing remote socket for transport=%s mode=%s driver=%s ro=%d session=%d",
remoteDriverTransportTypeToString(transport),
remoteDriverModeTypeToString(mode),
driver, ro, session);
if (driver)
direct_daemon = g_strdup_printf("virt%sd", driver);
@ -208,12 +213,9 @@ remoteGetUNIXSocket(remoteDriverTransport transport,
return NULL;
}
VIR_DEBUG("Chosen UNIX sockname=%s daemon=%s "
"for mode=%s transport=%s ro=%d session=%d",
VIR_DEBUG("Chosen UNIX sockname=%s daemon=%s with mode=%s",
sock_name, NULLSTR(*daemon),
remoteDriverModeTypeToString(mode),
remoteDriverTransportTypeToString(transport),
ro, session);
remoteDriverModeTypeToString(mode));
return sock_name;
}